ClearTK / cleartk

Machine learning components for Apache UIMA
http://cleartk.github.io/cleartk/
Other
130 stars 58 forks source link

remove org.cleartk.syntax.constituent.util.TreebankNode and friends #243

Open bethard opened 9 years ago

bethard commented 9 years ago

Original issue 245 created by ClearTK on 2011-04-21T12:40:32.000Z:

Is there a reason what we create util.TreebankNode objects instead of just type.TreeBankNode objects? That is, why do we create plain old Java objects and then immediately call the convert method to make them UIMA objects rather than just creating UIMA objects directly?

bethard commented 9 years ago

Comment #1 originally posted by ClearTK on 2011-04-22T02:48:40.000Z:

I think when I first wrote it this way I was considering the possibility of using the code outside the context of UIMA. I think it is quite safe to directly create the "UIMA" objects instead.

bethard commented 9 years ago

Comment #2 originally posted by ClearTK on 2012-07-24T17:54:00.000Z:

<empty>

bethard commented 9 years ago

Comment #3 originally posted by ClearTK on 2013-02-17T17:14:49.000Z:

<empty>

bethard commented 9 years ago

Comment #4 originally posted by ClearTK on 2013-02-21T15:49:28.000Z:

FYI, I ran into something similar in cTAKES, which is why there are the UIMA-type trees (that follow cleartk) as well as the SimpleTree type which is outside of uima and is good for things like doing tree transformations for tree kernel learning without modifying something in the cas that may be used downstream.

bethard commented 9 years ago

Comment #5 originally posted by ClearTK on 2013-05-03T08:44:33.000Z:

<empty>

bethard commented 9 years ago

Comment #6 originally posted by ClearTK on 2013-05-03T08:49:53.000Z:

<empty>

bethard commented 9 years ago

Comment #7 originally posted by ClearTK on 2014-03-15T17:41:52.000Z:

<empty>