search

ClearTK / cleartk

Machine learning components for Apache UIMA
http://cleartk.github.io/cleartk/
Other
129 stars 58 forks source link

make classifier constructors take InputStream instead of JarFile #91

Closed bethard closed 9 years ago

bethard commented 9 years ago

Original issue 93 created by ClearTK on 2009-04-30T13:59:54.000Z:

right now the constructors for the classifiers require a jar file. This is not ideal for the viterbi classifier which has a classifier model inside its jar file that it needs to use to instantiate the delegated classifier. This means that the viterbi classifier has to extract the jar file before it can instantiate the delegated classifier. It would be better if we re-factored the constructors to take an input stream such as the JarInputStream. Fixing this will require changes to ClassifierFactory and probably ClassifierManifest.

bethard commented 9 years ago

Comment #1 originally posted by ClearTK on 2009-10-27T16:41:59.000Z:

ViterbiClassifier wouldn't have to write a temp file if it took an InputStream. However, this wouldn't solve the LIBSVMClassifier problem - it still needs to write a temp file because LIBSVM can only read from an actual path. So as long as another classifier is having to write temp files, I don't think there's a good reason to change this.

bethard commented 9 years ago

Comment #2 originally posted by ClearTK on 2011-02-01T11:19:09.000Z:

This issue was closed by revision r2384.