ClearURLs / Addon

ClearURLs is an add-on based on the new WebExtensions technology and will automatically remove tracking elements from URLs to help protect your privacy.
http://docs.clearurls.xyz
GNU Lesser General Public License v3.0
4.06k stars 111 forks source link

?ref=producthunt #34

Closed grahamperrin closed 6 years ago

grahamperrin commented 6 years ago

For example,

https://mapsofmind.com/?ref=producthunt referred from https://www.producthunt.com/posts/mapsofmind

KevinRoebert commented 6 years ago

Thank you for the notification. I will think of something to implement this.

Update is on the way :) proof_curl_mapsofmind

KevinRoebert commented 6 years ago

Can anybody confirm the update?

Thorin-Oakenpants commented 6 years ago

https://github.com/KevinRoebert/ClearUrls/commit/3d7e3a4977376adc4feb4c9d4f0160cee58cce06 - is this update/fix related to this issue?

When I look at our repo's traffic (you'll have to use yours under Insights>Traffic to see what I mean), and wish to drill down into one of the top 10 domains (eg reddit), then, what happens is the page loads, the ClearURLs badge briefly flickers with 1, and then the page returns to the Traffic url and the ClearURL badge is clear again (because the page changed), and the whole thing happens in the blink of an eye

I am also unable to get anything in the logger.

example

where I try to view a link such as https://github.com/user/repo/graphs/traffic?referrer=reddit.com#top-domains

The only way to stop this is to disable ClearURLs, but as I said, I couldn't catch anything in the logger for some reason.

I'm just guessing that ?referrer=* is being blocked here via that patch?

KevinRoebert commented 6 years ago

The last patch actually causes this behavior. The rule [a-zA-Z_]*ref[a-zA-Z_]*=[^\/|\?|&]*(\/|&(amp;)?)? Blocks the request.

I will write an exception for github. Most of the time the ref fields are just for tracking, so we block them globally and then have to write exceptions for non-tracking pages, e.g. github.

Can anybody confirme the patch?