ClearURLs / Rules

Rules database of the ClearURLs WebExtension.
https://docs.clearurls.xyz/latest/specs/rules/
GNU Lesser General Public License v3.0
130 stars 51 forks source link

WIP: Fix microsoft Research redirects #95

Closed mskiptr closed 7 months ago

mskiptr commented 7 months ago

Hello, I've noticed that pruning the ?ref= parameter on some Microsoft URLs can break redirects there.

More specifically when I visit a page like http://research.microsoft.com/users/lamport/tla/tla.html, I am redirected to https://www.microsoft.com/en-us/research/redirect/?ref=https://research.microsoft.com/users/lamport/tla/tla.html which is transformed by one of the rules to just https://www.microsoft.com/en-us/research/redirect/. This obviously can't work, so I ultimately get to the main MS Research page (at https://www.microsoft.com/en-us/research/?from=https://research.microsoft.com&type=no-match).

Some other links that get broken because of this are:

and in general, any other Microsoft Research URL I can find in the wild.

i've tried fixing the problem by excluding these research/redirect links from the rule that filters ?ref=. Does it look alright? How should I go about testing it?

Nitpicks are welcome. Once all is clear I'll submit a non-draft version. @KevinRoebert.

KevinRoebert commented 7 months ago

LGTM. However, I cannot merge directly into the master via this PR, as GitHub only has a clone of the actual repo (which is at GitLab). So I will take your commit and merge it directly into the master at GitLab.

mskiptr commented 7 months ago

Thanks! I wasn't sure if the proper way is here or via GitLab. Github seemed to have more recently accepted contributions so I went with that. I actually tend to avoid unnecessary merge commits, but it's your repo so if you like them that's fine.