NyxIsBad
commented
1 year ago There are a lot of border: none in the code, fixing just one doesn't mean very much. I understand the reasoning behind it, but this could have been better communicated as an Issue that could be easily solved by a CTRL+H. I'm mostly just denying this for code quality reasons.
To address your concerns about accessibility, we are not creating CSS that could be worse for accessibility, we are modifying existing CSS that is already optimized for it (and even has a full on accessibility and high contrast mode built in).
That is to say the point of the border: none; in our code is to remove an already existing colored border that discord has for the sake of style, but we aren't in an environment where we need to account for accessibility, because discord handles this for us already when it comes to keyboard shortcuts/focus modes using their own settings (you'll notice when you tab around in discord a bright blue border comes up that's completely unrelated to the classes we modify, that's discord stepping in)
7agabond
Small accessibility defect in CSS when using "outline: none" was fixed. Made simple changes following best practices to prevent users with higher contrasts from experiencing bugs when using the tab key to select buttons, inputs, etc. Reference: https://www.youtube.com/shorts/4B_4WLpbyp8