search

ClearVision / ClearVision-v6

Highly customizable theme for BetterDiscord.
https://clearvision.github.io/
Apache License 2.0
385 stars 1.89k forks source link

Fixed codeblocks being smaller than it actually is #98

Closed Endy3032 closed 2 years ago

Endy3032 commented 2 years ago

Fixes #90

NyxIsBad commented 2 years ago

Thanks for doing the searching for me! I'm terribly sorry for being unable to address this earlier, I just kept forgetting about it and ghosting you (really my bad). I've run this locally and it seems not to cause any theme conflicts. For the sake of consistency, do you mind deleting the line entirely s.t. it looks like this?

// CODEBLOCK
  %codePre {
    padding: 0;
    background: transparent;
    border: 2px solid hsla(0, 0%, 100%, 0.05);
    border-radius: 8px;
    font-family: cv('font.code');
    & > %codeHLJS {

If so I'll approve and merge

untuned commented 2 years ago

Updated comment to auto close the attached issue when merged

Endy3032 commented 2 years ago

Thanks for doing the searching for me! I'm terribly sorry for being unable to address this earlier, I just kept forgetting about it and ghosting you (really my bad). I've run this locally and it seems not to cause any theme conflicts. For the sake of consistency, do you mind deleting the line entirely s.t. it looks like this?

// CODEBLOCK
  %codePre {
    padding: 0;
    background: transparent;
    border: 2px solid hsla(0, 0%, 100%, 0.05);
    border-radius: 8px;
    font-family: cv('font.code');
    & > %codeHLJS {

If so I'll approve and merge

Yeah no problem!

Endy3032 commented 2 years ago

do you mind deleting the line entirely s.t. it looks like this?

If so I'll approve and merge

Just got home and removed the line entirely just like you said