search

ClearcodeHQ / pytest-postgresql

This is a pytest plugin, that enables you to test your code that relies on a running PostgreSQL Database. It allows you to specify fixtures for PostgreSQL process and client.
https://pypi.python.org/pypi/pytest-postgresql/
GNU Lesser General Public License v3.0
428 stars 44 forks source link

add support for `\` character in pytest temporary path - Closes #982 #985

Closed bhelgs closed 2 months ago

bhelgs commented 4 months ago

Description

add support for \ character in pytest temporary path - Closes #982

Testing:

You can see I have broken the PR into two commits. In the first commit the new test fails on a "good" machine (XFAIL): image The second commit adds the fix. The tests PASSED on both "good" and "bad" machines: image

Chore

Chore that needs to be done:

P.S.

I noticed flake8 is failing in the pre-commit hook. I'll assume I should be using ruff now and the hook is just out of date..

fizyk commented 4 months ago

🤔 pre-comit-config hasn't been updated in years, don't mind it for the time being. It should be addressed separately

codecov-commenter commented 4 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.83%. Comparing base (22944af) to head (a24d7dc). Report is 233 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #985 +/- ## ========================================== + Coverage 95.26% 95.83% +0.57% ========================================== Files 13 13 Lines 401 432 +31 ========================================== + Hits 382 414 +32 + Misses 19 18 -1 ``` | [Flag](https://app.codecov.io/gh/ClearcodeHQ/pytest-postgresql/pull/985/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClearcodeHQ) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ClearcodeHQ/pytest-postgresql/pull/985/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClearcodeHQ) | `95.83% <100.00%> (+0.57%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClearcodeHQ#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bhelgs commented 2 months ago

I have rebased this change on top of our other recent updates.

The test confirms the path can contain backslashes, "\", as well as spaces, " ".