Clem-Fern / rtabby-web-api

Tabby Web API for Config Sync
GNU Affero General Public License v3.0
61 stars 4 forks source link

ARM64 Support #14

Closed Cysime closed 8 months ago

Cysime commented 10 months ago

Hi,

Thanks for this implement of sync API for Tabby. I found that this project is not ARM64 ready by default, but it's quite easy to add the ARM64 support.

All we need to do is clone the project, uncomment the build section in docer-compose file, and modify the Dockerfile, change x86_64into aarch64, and it runs smoothly without any issue.

# syntax=docker/dockerfile:1
FROM rust:1.73-alpine AS builder
WORKDIR /build
COPY . .
RUN apk add --no-cache build-base && \
    cargo build --target=aarch64-unknown-linux-musl --release --no-default-features -F sqlite-bundle

FROM scratch

WORKDIR /config

COPY --from=builder /build/target/aarch64-unknown-linux-musl/release/rtabby-web-api /
COPY --from=builder /build/users.exemple.yml .

CMD ["/rtabby-web-api"]
Clem-Fern commented 10 months ago

Hey,

Could be great to have arm platform directly available in the package registry. I will try to add this in the current build workflow :)

Clem-Fern commented 8 months ago

Hi @Cysime,

I added arm64 platform in CI. Build in progress. Could you please make me a feedback ? I don't have any arm device to test :/

bigwave commented 8 months ago

Works for me on Raspberry Pi 4 Model B Rev 1.5

Clem-Fern commented 8 months ago

Works for me on Raspberry Pi 4 Model B Rev 1.5

@bigwave Thank's for the feedback