search

Clem-Fern / rtabby-web-api

Tabby Web API for Config Sync
GNU Affero General Public License v3.0
62 stars 4 forks source link

Enable HTTPS callback URI when behind reverse proxy #21

Closed dashrandom closed 7 months ago

dashrandom commented 7 months ago

Hello, I'm having a bit of an issue as I'm using a reverse proxy to generate and store my SSL certs but when using the oauth login the callback URI is a plain HTTP url, making it fail.

Is there a way I can enable HTTPS for the callback URI without uploading a cert.pem and cert.key file? Thanks!

Clem-Fern commented 7 months ago

Hey @dashrandom

You should be able to enable https on login callback by adding USE_HTTPS env variable set to true.

I just saw that I forgot to document this option when I published the latest release. Sorry about that.

dashrandom commented 7 months ago

Thanks for replying @Clem-Fern ! I tried with USE_HTTPS=true but it still doesn't seem to be working. I'm getting the same issue about the callback URI being in plain http.

image

Do I need to expose port 443 from the container instead of 8080 when using the above env variable?

Clem-Fern commented 7 months ago

Hey @dashrandom,

0.4.2 version should fix your issue. I replace USE_HTTPS by HTTPS_CALLBACK and rewrite a bit of code around it.

Release and container image should be available soon (build in progress).

dashrandom commented 7 months ago

Much appreciated @Clem-Fern !