ClemBotProject / ClemBot

A Discord bot for server management with an emphasis on modularity and configuration. If you have an idea or a feature you would like to contribute feel free to open an issue and we as a community can begin discussion.
https://clembot.io
MIT License
83 stars 57 forks source link

Bug: Trashcan Emoji Does Not Timeout for Several Commands #638

Closed Exper1mental closed 10 months ago

Exper1mental commented 2 years ago

I noticed the other day that several of ClemBot's commands appear to have no trashcan emoji timeout, meaning that anytime in the future the command query author can click the trashcan for ClemBot to delete the message. Specifically, I noticed that an !info command message I had sent half a day before still had the trashcan, and when pressed still deleted the message.

If I understand correctly, this also means that ClemBot is basically creating and storing an ever-growing list of messages in the self.messages array of delete_message_service.py until the bot crashes or restarts.

Commands confirmed to have the issue

Commands suspected to have the issue

Commands that do not have the issue

Anything not listed hasn't been checked by me.

By suspected, I mean that I haven't tried pressing the trashcan on the output from one of these commands to confirm ClemBot will still delete the message.

Example

image

Jay-Madden commented 2 years ago

The info command doesn't have a set timeout, it will last for as long as the bot hasn't restarted, adding a timeout is trivial if we want to do that

arock475 commented 10 months ago

Could I be added to this issue? And clarifying question, would you prefer adding a default timeout value or adding a timeout value to each of the services which do not have it?