Closed connorfuhrman closed 2 years ago
Mutex
error:
ThreadPool
error:
// in .src/multi_thread.inl
namespace detail
{
template<typename Result_t>
struct TaskValue : public detail::TaskSuper
{
friend class ThreadPool; // here
This friend declaration inherited the above namespace, triggering detail::ThreadPool to be declared but not defined. I assume the fact this triggers an error is due to a subtle difference between how G++-10 and 11 solve ambiguity.
Either way, it was fixed by https://github.com/Clemapfel/jluna/pull/22
Thank you for contributing!
I encounters some build issues with version 0.9.0 when building in Ubuntu 20.04.
mutex
isn't a member ofnamespace std
and had to add a#include
directive insafe_utilities.cpp
ThreadPool
is ambiguous in a testing file and had to explicitly resolve namespace in friend class inmulti_threading.inl
I was able to install and
ctest
did not report any errors so I'm assuming these changes are correct :shrug: . These are small changes so I'll submit a PR quickly and let y'all determine if my errors are one-offs or not.OS: Ubuntu 20.04 Compiler: GCC 11 (installed via
apt
)