search

Clemapfel / jluna

Julia Wrapper for C++ with Focus on Safety, Elegance, and Ease of Use
https://clemens-cords.com/jluna
MIT License
252 stars 13 forks source link

Use Julia new foreign thread support #26

Closed cdsousa closed 2 years ago

cdsousa commented 2 years ago

Possibly this is not new news for you, but Julia is about to support foreign threads calling into it: https://github.com/JuliaLang/julia/pull/45447. This will probably be very helpful and simplify jluna.

Clemapfel commented 2 years ago

I was aware of this PR but I'm not sure if I want to bump up the version requirement for Julia to something this new, I'd like it to stay at 1.7.

If this will be part of the 1.8 stable release then I'll definitely consider reworking the threadpool interface

cdsousa commented 2 years ago

This will be only in 1.9. I agree you don't need to add this as soon as possible, I opened this issue more to raise awareness that such a new feature may be useful for this package in the future. Feel free to close this for now if you prefer 😉

Clemapfel commented 2 years ago

Considering the amount of jank I had to implement to get the jluna threadpool to work, it was appropriate to point out - so thank you! Hopefully they also fix @threadcall which is currently unusable because of how the C-API work.