search

Clemapfel / jluna

Julia Wrapper for C++ with Focus on Safety, Elegance, and Ease of Use
https://clemens-cords.com/jluna
MIT License
239 stars 12 forks source link

Implement Task's operator unsafe::Value*() + minor fixes #31

Closed paulerikf closed 1 year ago

paulerikf commented 1 year ago

Draft PR which fixes #30. Also small fixes to Task<void>'s destructor, is_done(), is_failed(). Finally, added specific tests for the Task case. I'm not attached to these at all, just a suggestion. Not sure if you want to organize them differently.

Noticed Proxy has const versions of the operator unsafe::Value*(), I'm not sure if Task should have that?

Clemapfel commented 1 year ago

Thank you! I may add the operator const unsafe::Value* const later, I need to check how it interacts with proxy assignment and not having it doesn't break anything afaik