Clemapfel / jluna

Julia Wrapper for C++ with Focus on Safety, Elegance, and Ease of Use
https://clemens-cords.com/jluna
MIT License
239 stars 12 forks source link

jl_set_global going away #34

Closed robertu94 closed 1 year ago

robertu94 commented 1 year ago

Jluna uses a function jl_set_global which seems to be going away in an upcoming version https://docs.julialang.org/en/v1.9-dev/manual/embedding/. I wasn't sure what the easy work around was otherwise I would have created a PR to adapt to this change.

Clemapfel commented 1 year ago

Thank you for making me aware of this, functionality-wise it's pretty easy to replace by just writing a Julia-side function and loading it on jluna::initialize, but the nice thing about jl_set_global is that it's super fast so I need to do some benchmarking to find a valid replacement.

I'll keep this open until I then, it shouldn't be that much work.

Clemapfel commented 1 year ago

Fixed by https://github.com/JuliaLang/julia/commit/3c3ec2e8462bad416a49872daf1401b0745029eb