search

Clemapfel / jluna

Julia Wrapper for C++ with Focus on Safety, Elegance, and Ease of Use
https://clemens-cords.com/jluna
MIT License
239 stars 12 forks source link

Usertype<T>::implement not respecting module argument #36

Closed paulerikf closed 1 year ago

paulerikf commented 1 year ago

This is not a high priority for me at all, but dropping an issue here since I noticed it the other day.

Usertypes seem to always be implemented in Main module scope, rather than the module specified in Usertype<T>::implement(unsafe::Module* module).

The module argument doesn't seem to be used at all: https://github.com/Clemapfel/jluna/blob/05a827c3eda6f4fa7891f238ed7550f3105ece72/.src/usertype.inl#L61-L81

Clemapfel commented 1 year ago

fixed by #37 once it's merged, the functionality was already implemented I just forgot to call it without the default argument.