Clemapfel / jluna

Julia Wrapper for C++ with Focus on Safety, Elegance, and Ease of Use
https://clemens-cords.com/jluna
MIT License
246 stars 14 forks source link

Inconsistent julia include directory #6

Closed melonedo closed 2 years ago

melonedo commented 2 years ago

This package uses both #include <julia/julia.h> https://github.com/Clemapfel/jluna/blob/b19f3a24c8b7f557241999ba6196e6cebf41c620/include/box.hpp#L14 and #include <julia.h> https://github.com/Clemapfel/jluna/blob/b19f3a24c8b7f557241999ba6196e6cebf41c620/include/typedefs.hpp#L8 for include, while the build commands configures the include directory as /path/to/include/julia, which makes the file include/box.hpp error during compilation. https://github.com/Clemapfel/jluna/blob/b19f3a24c8b7f557241999ba6196e6cebf41c620/CMakeLists.txt#L33 https://github.com/Clemapfel/jluna/blob/b19f3a24c8b7f557241999ba6196e6cebf41c620/CMakeLists.txt#L54 I am not sure whether I missed anything. Anyway, it is exciting to see this package!

Clemapfel commented 2 years ago

hotfixed here, thank you for pointing this out