search

Clemens85 / runningdinner

Mono-Repo containing Java backend, React Frontend and Lambdas
https://runyourdinner.eu
MIT License
3 stars 2 forks source link

Fix German "E-Mail" spelling, minor improvement #66

Closed danleh closed 7 months ago

danleh commented 8 months ago

... of newlines in registration email.

Clemens85 commented 8 months ago

Thanks for the enhancement. To be honest I never cared about the spelling, there are several valid ways, both E-Mail and Email is valid as far as I know. Having said that, I can also just merge this, because E-Mail is just as good for me. But, there are also other translation bundles in the webclient (far more than in the backend, refer to runningdinner-client/shared/src/i18n/translations), and those should then also be adapted to have a consistent spelling.

danleh commented 8 months ago

Ah, good point, I changed the German spelling in the other translation bundles (and a few Java files that didn't use i18n) as well now.

Clemens85 commented 8 months ago

Sorry, I still found at least one translation with the old style (e.g. "EMail für Rückfragen (wird in Event angezeigt" -> CommonMessages_lang_de.json)

danleh commented 8 months ago

Oops, thanks. I had only looked for "Email", now I also changed "EMail" in the German translations.