search

ClemensElflein / OpenMower

Let's upgrade cheap off-the-shelf robotic mowers to modern, smart RTK GPS based lawn mowing robots!
Other
4.7k stars 281 forks source link

Fix typo #104

Closed rovo89 closed 5 months ago

rovo89 commented 5 months ago

Otherwise whenever any hall sensor triggers, it will trigger the STOP emergency bits after just 20 ms, instead of waiting 2500 ms (for tilt) or 100 ms (for lift). Actually no, because only bits which are really in emergency_read are set. So worst case would be that some other hall sensor triggers the timer too early. It's still wrong though.

Already confirmed with @Apehaenger that this wasn't intended.

ClemensElflein commented 5 months ago

Thank you for the PR, nice find