Closed Apehaenger closed 5 months ago
Good idea, AFAICT, this is already part of #80? Should we close this PR then?
No. Only the #defines are in #80 the logic change and the corrected emergency comments are here.
Corrected online. Not validated yet. To late now :-( Will do tomorrow and add a further comment.
Recognized that @kevinmce also had some emergency-bit confusion in his cool #71, like me (during my Stock-CoverUI development).
Tried to clear that up by evaluating the whole chain from Hall-x labels on the PCB, PIN_EMERGENCY_x definitions, up to the emergency logic, with comparing the the actual doc on a 0.9.x OM-MB, and also cross checked PCB Hall- labeling with PIN_EMERGENCY_x definition on the 0.13 schematics. Beside my further tries to make that part some easier to read, I did not changed any emergency bit position, but corrected the (in my point of view) wrong comments.
Because testing take mostly longer than coding, I would like to ask before, what do you think about my adjustements and if you're interested to merge, if it got tested?