Clear stock- emergency if CoverUI get unplugged

ClemensElflein / OpenMower

Let's upgrade cheap off-the-shelf robotic mowers to modern, smart RTK GPS based lawn mowing robots!

Other

4.64k stars 274 forks source link

Clear stock- emergency if CoverUI get unplugged #82

Closed Apehaenger closed 5 months ago

Apehaenger commented 10 months ago

Current behavior

If Stock-CoverUI triggers an emergency and get unplugged, emergency state can't be cleared anymore. Except by reboot.

New behavior

If UI-Avail code block detects that UI isn't available anymore, the save stock-emergency state get also cleared

Conclusion

Sure, this is not a real practical use-case, because normally no one unplugs his CoverUI while the mower is up. But it's possible (and I do it quite often ;-))

ClemensElflein commented 5 months ago

what's the status on this one? PR points to your main, so there's currently a lot of changes (I think most of them for #80)

Apehaenger commented 5 months ago

Oh, I'm sorry. Started to merge all my preferred PRs in my main branch. Bad idea :-/

This PR is only this one line in commit https://github.com/ClemensElflein/OpenMower/pull/82/commits/89247a40042e45e5bea713b119896c7cf91443ef Is it possible to merge only that single commit?

ClemensElflein commented 5 months ago

Thank you for the feedback, I have cherry-picked the commit onto main: https://github.com/ClemensElflein/OpenMower/commit/267df89c5546eb71686a738d972c60973eecdb51

I'll close this PR now.