Closed ClemensElflein closed 2 months ago
Often saw that 'non-icon' during development, which was always founded by a dirty cache.
However, just tested to be sure...
Firefox @ Desktop:
Smartphone:
Please be so kind and check again with cleared cache... or cleared nginx cache?
I did my tests today and here is my test plan with the results
works by and large without any problems, minor findings
OM_HARDWARE_VERSION="0_11_X_WT901"
(Vermut's kit)sudo podman pull ghcr.io/clemenselflein/open_mower_ros:sha-ad86905
(Tag pr-101
)Comment: I did not see a description, how the gui should behave so I describe the results I found and comment them with what I think should be correct
OM_UNDOCK_DISTANCE
OM_UNDOCK_DISTANCE
. If someone configured the distance in OM_UNDOCK_DISTANCE
for a good reason, than this is not respected in the current scenarioI'd change the wording of the message box and I see no obstacle reason not to merge the PR into main, because I think the possibility to cancel the emergency state in the gui outweighs the mentioned findings (probably relative rare edge cases and I would assume most not caused by the changes in the gui but always have been there in the background and just became visible now) - but I'm not the expert to make this judgment. Sorry for the somewhat lengthy description ... but once you get started ;) ... and I hope, nevertheless useful
Quite thanks for detailed testing and your very detailed report!!
I'm not a mowing-behavior expert, nor looked to the sources, but regarding your point "3.iii subpoint 3" I would expect that behavior because you "stopped" (go home (docking)), "paused" the docking phase and then released the pause with "start"? So it will finish the docking phase? Sound at least reasonable to me ;-)
Quite thanks for detailed testing and your very detailed report!!
I'm not a mowing-behavior expert, nor looked to the sources, but regarding your point "3.iii subpoint 3" I would expect that behavior because you "stopped" (go home (docking)), "paused" the docking phase and then released the pause with "start"? So it will finish the docking phase? Sound at least reasonable to me ;-)
I have looked at this again and I agree with you: the behavior is correct/consistent
However, the gui is misleading, as it shows only one layer of state and by this, pretends that for instance "mowing" and "paused" are states on the same layer, which is obviously not the case. "paused" is something like a sub-state or additional property of "mowing" or "docking" (similar to the emergency state; sorry I don't know how the state machine is actually implemented, but I think I must be something like that)
So what would make the gui clearer to me would be: always show the 'main state' (like 'mowing') and keep updating this whenever it changes (behind the scenes) and then whenever the 'sub state' 'paused' becomes true, show the additional flag 'paused' (while still showing the 'main state') .
In my test scenario this would yield:
I don't know how much work this change would be or if it has undesirable side effects. For me it's not vital because it will rarely happen (and I understand it now ;) ) But for 'normal' users, who are not so much into the internals, it would make the gui more speaking.
BTW: I pulled the new image (sha-dd7a4a2) with the changed wording => fine
Ahm, may I annoy you with another thought on the states: when lift emergency is triggered while mowing, the gui shows "paused" AND "emergency". I think these are/should be two independent concepts and only "emergency" should be shown. If the mower really is "paused", I'd expect, that it does not go on mowing immediately after clearing emergency - because it's paused. It does this correctly, when I first pause mowing and than trigger lift emergency: the gui shows the same ("paused" AND "emergency") but after clearing emergency it does not continue mowing, because it is in "paused" sub state. This is an inconsistency, as the gui shows the same but the mower behaves different. ... or does the gui just show the string "paused", when emergency is triggered, but has no correlation with the underlying state machine - then it would only be a gui/view thing and I'd suggest not to show "paused" but leave "mowing" displayed, as it is not really paused but in emergency. (sorry for my complicated writing, I find it hard to express this in English and nevertheless hope that my point is understandable)
Thank you for the PR @Apehaenger and thank you for testing @Max07B2. I think the state discussion is different from the user interface and should be moved to a separate issue / PR.
Tested the PR, found a missing icon. Battery symbol is not showing while mowing.