Fix empty mowing path check

ClemensElflein / open_mower_ros

Other

498 stars 122 forks source link

Fix empty mowing path check #106

Closed olliewalsh closed 3 months ago

olliewalsh commented 3 months ago

size_t is unsigned so can wrap around

rovo89 commented 3 months ago

Good catch! I wasn't sure whether it would handle the values as unsigned internally (and wrap only if you stored the result in a variable), but indeed it's as you said, just verified it.

By the way, it's a bit disturbing that the "build" checks fail, when in fact only the push of the image fails...

ClemensElflein commented 3 months ago

Nice catch, thanks for the PR

@rovo89 yes, I'm not even sure why the push fails on these PR builds, it worked before. I'll have to look into this at some point (I want the push, so that testing a PR is easy for people)