search

ClemensElflein / open_mower_ros

Other
500 stars 124 forks source link

"Start in area" service implementation #66

Closed nitescuc closed 1 month ago

nitescuc commented 1 year ago

Add a new service allowing to start in a given area number.

The service has to clear the eventual remaining path, otherwise the mower will start by executing it instead of clean start of the given area. To do this I use a configuration parameter "clear_path_on_start" which was convenient because it doesn't care which behavior is the current one.

ClemensElflein commented 6 months ago

I like the idea, but the configurations should not take care of clearing the path.

I think it should be possible similar to what @olliewalsh suggested (call the method on the currentBehavior). I can also have a look at this as soon as I'm through with checking all PRs. For now I'll leave this one open.

2m commented 3 months ago

I was using this change on my OM from the end of last summer until now. I would like to update to the latest OM version and to keep this functionality. I have rebased this branch on top of latest main here: https://github.com/2m/open_mower_ros/commit/2bcfbaa326c536706120cdcad313179f5c2985c5

I understand that the implementation is not ideal and some comments are still to be addressed. But I will try the current state of these changes with the latest main and will report back.

EDIT: ahh, simple rebase will not do. It does not compile. Will see if I can adapt to the current state in main.

EDIT2: so the current_area is gone from the MowerLogicConfig after https://github.com/ClemensElflein/open_mower_ros/pull/62 So this PR will definitely need to be reworked as propsed here in the commends.

midevil commented 2 months ago

Ah, this explains why this does not work anymore, i was running on PR66 since oktober last year, decided to update to main and... it's gone. So rework? Or open a new PR ?

ClemensElflein commented 2 months ago

I think we can do new PR since implementation will differ anyways