Clement134 / get-changelog

A CLI tool to easily find changelogs
MIT License
22 stars 3 forks source link

Change log url not shown #210

Closed smmoosavi closed 2 years ago

smmoosavi commented 2 years ago

Describe the bug

Change log url not show.

get-changelog -c

┌────────────────────────────────────────────────────────────┬─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Package                                                    │ Changelog                                                                                                       │
├────────────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ @types/relay-runtime (11.0.3 > 12.0.0)                     │ Changelog                                │
├────────────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ make-plural (6.2.2 > 7.0.0)                                │ Changelog                                             │
├────────────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ @emotion/cache (11.4.0 > 11.5.0)                           │ Changelog                    │

To Reproduce Steps to reproduce the behavior:

  1. run get-changelog -c

Expected behavior show url

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Clement134 commented 2 years ago

Hi, If your terminal support hyperlinks, the url are not printed directly in the table report and links are used instead. I suppose this is the case in your example output.

smmoosavi commented 2 years ago

I am using terminator 1.91, but they are not clickable.

Clement134 commented 2 years ago

I just tried with terminator 2.1.1 on archlinux and changelog hyperlinks are clickable (with ctrl + click): image

Clement134 commented 2 years ago

@smmoosavi could you check if the links are clickable with ctrl + click on your side?

smmoosavi commented 2 years ago

No, they are not working with ctrl + click

smmoosavi commented 2 years ago

I modified the code on my local machine:

-        const changelogLink = terminalLink('Changelog', changelog, {
-            fallback: () => changelog,
-        });
+        const changelogLink = changelog;

and they work for me

Clement134 commented 2 years ago

By doing this you bypass terminalLink which is used to format clickable hyperlink on the terminal. I don't know why terminalLink is not working properly on your environment. Perhaps we could had an option to force full link rendering even if the terminal supports hyperlinks.

Clement134 commented 2 years ago

It should be fixed with the new -u option available in version 3.0.0.

get-changelog -cu