search

ClementPerroud / Gym-Trading-Env

A simple, easy, customizable Gymnasium environment for trading.
https://gym-trading-env.readthedocs.io/
MIT License
270 stars 56 forks source link

add get_log function #3

Closed BY571 closed 1 year ago

BY571 commented 1 year ago

Hey, I wanted to start by saying that I think your project is great, and I'm excited to see the backtesting features you're planning to add. I was wondering if you had considered including a function to retrieve metrics that could be easily logged to platforms like wandb or TensorBoard. It seems like this could be a useful addition for users who want to track and analyze the performance of their trading strategies.

ClementPerroud commented 1 year ago

Hi I just implemented your idea using the code ! I had to modify some parts to avoid some code to run twice. I already committed it to main branch, so I won't merge your PR (sorry I am not familiar with Github yet) ! Now you can use :env.get_metrics() at the end of an episode I also edited the docs : Custom logs I would love to have your opinion about it!

BY571 commented 1 year ago

Hi I just implemented your idea using the code ! I had to modify some parts to avoid some code to run twice. I already committed it to main branch, so I won't merge your PR (sorry I am not familiar with Github yet) ! Now you can use :env.get_metrics() at the end of an episode I also edited the docs : Custom logs I would love to have your opinion about it!

Sounds good, did you push your changes already? I dont see them in the code yet only the docs changed.

ClementPerroud commented 1 year ago

You are right, now It is pushed !