ClementTsang / bottom

Yet another cross-platform graphical process/system monitor.
https://clementtsang.github.io/bottom
MIT License
9.91k stars 234 forks source link

refactor: some string-related code cleanup/refactor #1463

Closed ClementTsang closed 4 months ago

ClementTsang commented 4 months ago

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

Checklist

If relevant, ensure the following have been met:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 83.10185% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 55.93%. Comparing base (bcc8917) to head (4fac790).

Files Patch % Lines
src/utils/strings.rs 93.72% 18 Missing :warning:
src/widgets/process_table/proc_widget_data.rs 40.00% 12 Missing :warning:
src/utils/data_prefixes.rs 65.62% 11 Missing :warning:
src/widgets/disk_table.rs 50.00% 10 Missing :warning:
src/widgets/process_table/sort_table.rs 0.00% 8 Missing :warning:
src/widgets/temperature_table.rs 14.28% 6 Missing :warning:
src/data_conversion.rs 89.65% 3 Missing :warning:
src/lib.rs 60.00% 2 Missing :warning:
src/canvas/components/data_table.rs 0.00% 1 Missing :warning:
src/canvas/components/data_table/sortable.rs 0.00% 1 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1463 +/- ## ========================================== + Coverage 55.84% 55.93% +0.09% ========================================== Files 97 99 +2 Lines 18190 18191 +1 ========================================== + Hits 10159 10176 +17 + Misses 8031 8015 -16 ``` | [Flag](https://app.codecov.io/gh/ClementTsang/bottom/pull/1463/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | Coverage Δ | | |---|---|---| | [macos-12](https://app.codecov.io/gh/ClementTsang/bottom/pull/1463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | `39.31% <65.27%> (-0.01%)` | :arrow_down: | | [ubuntu-latest](https://app.codecov.io/gh/ClementTsang/bottom/pull/1463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | `58.54% <83.10%> (+0.09%)` | :arrow_up: | | [windows-2019](https://app.codecov.io/gh/ClementTsang/bottom/pull/1463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | `39.49% <65.73%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.