ClementTsang / bottom

Yet another cross-platform graphical process/system monitor.
https://clementtsang.github.io/bottom
MIT License
9.91k stars 234 forks source link

refactor: use struct for args instead of builder interface #1472

Closed ClementTsang closed 4 months ago

ClementTsang commented 4 months ago

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

Checklist

If relevant, ensure the following have been met:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 75.56391% with 65 lines in your changes are missing coverage. Please review.

Project coverage is 40.95%. Comparing base (71f6136) to head (74569e1).

Files Patch % Lines
src/options/args.rs 32.60% 31 Missing :warning:
src/options.rs 88.04% 22 Missing :warning:
src/data_collection/temperature.rs 0.00% 9 Missing :warning:
src/lib.rs 75.00% 2 Missing :warning:
src/widgets/process_table.rs 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1472 +/- ## ========================================== - Coverage 42.81% 40.95% -1.86% ========================================== Files 99 99 Lines 17940 17462 -478 ========================================== - Hits 7681 7152 -529 - Misses 10259 10310 +51 ``` | [Flag](https://app.codecov.io/gh/ClementTsang/bottom/pull/1472/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | Coverage Δ | | |---|---|---| | [macos-12](https://app.codecov.io/gh/ClementTsang/bottom/pull/1472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | `36.32% <75.56%> (-2.15%)` | :arrow_down: | | [ubuntu-latest](https://app.codecov.io/gh/ClementTsang/bottom/pull/1472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | `42.91% <75.56%> (-1.90%)` | :arrow_down: | | [windows-2019](https://app.codecov.io/gh/ClementTsang/bottom/pull/1472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | `36.45% <75.84%> (-2.19%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.