ClementTsang / bottom

Yet another cross-platform graphical process/system monitor.
https://clementtsang.github.io/bottom/
MIT License
9.32k stars 219 forks source link

other: add schema test for uncommented default config #1484

Closed ClementTsang closed 2 weeks ago

ClementTsang commented 2 weeks ago

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Add a test for an uncommented variant of the default config file.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

Checklist

If relevant, ensure the following have been met:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 51.69492% with 57 lines in your changes missing coverage. Please review.

Project coverage is 40.84%. Comparing base (7666a09) to head (068fa73).

Files Patch % Lines
src/main.rs 3.33% 29 Missing :warning:
src/options/config/process.rs 70.58% 25 Missing :warning:
src/options.rs 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1484 +/- ## ========================================== + Coverage 40.83% 40.84% +0.01% ========================================== Files 102 102 Lines 17547 17620 +73 ========================================== + Hits 7165 7197 +32 - Misses 10382 10423 +41 ``` | [Flag](https://app.codecov.io/gh/ClementTsang/bottom/pull/1484/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | Coverage Δ | | |---|---|---| | [macos-12](https://app.codecov.io/gh/ClementTsang/bottom/pull/1484/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | `36.21% <51.69%> (+0.02%)` | :arrow_up: | | [ubuntu-latest](https://app.codecov.io/gh/ClementTsang/bottom/pull/1484/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | `42.79% <51.69%> (+<0.01%)` | :arrow_up: | | [windows-2019](https://app.codecov.io/gh/ClementTsang/bottom/pull/1484/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang) | `36.35% <51.69%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clement+Tsang#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.