search

Clemson-DPA / dpa-pipe

DPA pipeline
MIT License
51 stars 13 forks source link

ProductSubscription.get() Parameters Switched #16

Closed mnemyx closed 9 years ago

mnemyx commented 9 years ago

In dpa/product/subscription/init.py: line 61 def get(cls, product_version_spec, ptask_version_spec, relative_to=None):

Testing in terminal: from dpa.product.subscription import ProductSubscription test = ProductSubscription.get('testdwa=dev=maritest=model=hero=products=maritest_model=workfile=0024','testdwa=dev=maritest=surface=hero@0004') Traceback (most recent call last): File "", line 1, in File "/home/gguerre/pipedev/dpa-pipe/dpa/product/subscription/init.py", line 77, in get return super(ProductSubscription, cls).get(spec) File "/home/gguerre/pipedev/dpa-pipe/dpa/restful/mixins.py", line 77, in get raise cls.exception_class(e) dpa.product.subscription.ProductSubscriptionError: {"detail": "Not found"}

josh-t commented 9 years ago

I will address this first thing in the AM.

On Jun 2, 2015, at 7:10 PM, Gina notifications@github.com wrote:

In dpa/product/subscription/init.py: line 61 def get(cls, product_version_spec, ptask_version_spec, relative_to=None):

Testing in terminal: from dpa.product.subscription import ProductSubscription test = ProductSubscription.get('testdwa=dev=maritest=model=hero=products=maritest_model=workfile=0024','testdwa=dev=maritest=surface=hero@0004') Traceback (most recent call last): File "", line 1, in File "/home/gguerre/pipedev/dpa-pipe/dpa/product/subscription/init.py", line 77, in get return super(ProductSubscription, cls).get(spec) File "/home/gguerre/pipedev/dpa-pipe/dpa/restful/mixins.py", line 77, in get raise cls.exception_class(e) dpa.product.subscription.ProductSubscriptionError: {"detail": "Not found"}

— Reply to this email directly or view it on GitHub.

josh-t commented 9 years ago

I've put in a fix. I will push out with some other changes shortly.

josh-t commented 9 years ago

Fixed and pushed out with release 0.0.14

josh-t commented 9 years ago

This fix was partial. I just pushed 2a37542e8222938cda1be51ccaf46610b851745b for the proper fix which corrects the rest which was swapping the ordering of the args to match all the other methods in the class. Let me know if there are problems.