search

ClevelandMuseumArt / openaccess

Creative Commons Zero v1.0 Universal
72 stars 9 forks source link

wording promotes using wrong query parameter to get only CC0 artworks #2

Closed JustinGOSSES closed 5 years ago

JustinGOSSES commented 5 years ago

A small point... I noticed on http://openaccess-api.clevelandart.org/ The wording in the line cc0 | integer | 0 or 1. Determines whether only CC0 artworks or returned or only not CC0 artworks. is confusing. Based on the ordering, I would have suspected that 0 is only CC0 artworks, but in fact CC0 artworks are retuned by 1.

To avoid confusion, maybe changed wording to: 0 or 1. Using 1 returns only CC0 artworks and 0 returns only artworks that have a license other than CC0.

ethanholda commented 5 years ago

I changed the language on this to (hopefully) make it clearer.

JustinGOSSES commented 5 years ago

There is an extra 'or' now.

0 or 1. Determines whether non-CC0 artworks or returned or only CC0 artworks.

try 0 or 1. Determines whether only non-CC0 artworks returned or only CC0 artworks returned.

ClevelandArtGIT commented 5 years ago

Typo. Should be fixed now.