Wishlist for v4

[azylman]

• Move all sources into the sources package instead of having their own packages
• Move all sinks into the sinks package instead of having their own packages
• Remove the csv source and sink that take in io.Reader/Writers in favor of csv.Reader/Writers
• Make the json source and sink configurable to be either an array of JSON documents or newline-separate JSON documents (this should probably be done prior to v4 in a backwards-compatible way, so we know what works before we remove the old method)
• Delete Join function and rename Pair to Join
• Make Unique take in a RowHasher instead of a UniqueHash
• Rename sources/error/ErrorTable to pass linting (error.ErrorTable stutters, should be error.Table or something - alternatively move this package to internal since it's primarily used for tests)

[azylman]

(some of these can be done in a backwards compatible manner if we don't mind adding cruft)

[MaerF0x0]

Just for my learning's sake, if all the sinks are in the package, does that mean changing 1 sink would require recompile of the whole package? Not a concern for this repo, just wanted to know.

[azylman]

This package is never compiled on its own, since it's a library. It's only compiled when some program imports it and is built.

[rgarcia]

Would the first two have a significant effect on binary size, since now you have to compile all sources and sinks into your program?

[azylman]

It will have an effect, but they're all small enough that I expect it to be small On May 27, 2015 5:07 PM, "Rafael" notifications@github.com wrote:

Would the first two have a significant effect on binary size, since now you have to compile all sources and sinks into your program?

— Reply to this email directly or view it on GitHub https://github.com/Clever/optimus/issues/16#issuecomment-106116508.

[jiancheung]

Wishlist: Replace Fieldmap with SafeFieldmap (https://github.com/Clever/optimus/pull/52)