search

Clever / optimus

Concurrently extract, transform, and load tables of data in Go
Apache License 2.0
34 stars 7 forks source link

transforms: add pair (join without merging rows) #18

Closed azylman closed 9 years ago

azylman commented 9 years ago

I've assigned this to @kvigen, but @templaedhel might be interested since he also needs this

azylman commented 9 years ago

Question: I'm pretty sure that the desired behavior when two rows hash to nil is that they DON'T pair, right? I believe anything that hashes to nil shouldn't be paired with anything. That's how it's implemented + tested here.

kvigen commented 9 years ago

i agree with your interpretation of nil in the join.

kvigen commented 9 years ago

Looks great, I just have a few nits. I'm totally going to use this right after you merge it :)