call source.Stop() in json & csv sink

Clever / optimus

Concurrently extract, transform, and load tables of data in Go

Apache License 2.0

34 stars 7 forks source link

call source.Stop() in json & csv sink #35

Closed nikhilpandit closed 9 years ago

nikhilpandit commented 9 years ago

If source.Stop() is not called in jsonSink.New and csvSink.New, it is possible that the Stop() never gets called if there is an error. This provides a fix for that case.

Testing: Tested manually, and added to the existing tests for json & csv sink.

azylman commented 9 years ago

lgtm