search

Clever / optimus

Concurrently extract, transform, and load tables of data in Go
Apache License 2.0
34 stars 7 forks source link

Tests break with Go 1.5.1 #40

Closed doodles526 closed 9 years ago

doodles526 commented 9 years ago 
TESTING...
=== RUN   TestGearmanSource
panic: runtime error: index out of range

goroutine 7 [running]:
gopkg.in/Clever/optimus.v3/sources/gearman.TestGearmanSource.func2(0xc82000a740)
        /Users/joshdeare/src/go/src/gopkg.in/Clever/optimus.v3/sources/gearman/gearman_test.go:57 +0xc67
created by gopkg.in/Clever/optimus.v3/sources/gearman.TestGearmanSource
        /Users/joshdeare/src/go/src/gopkg.in/Clever/optimus.v3/sources/gearman/gearman_test.go:61 +0x7d0

goroutine 1 [chan receive]:
testing.RunTests(0x476ec8, 0x59d2a0, 0x2, 0x2, 0x1)
        /usr/local/Cellar/go/1.5.1/libexec/src/testing/testing.go:562 +0x8ad
testing.(*M).Run(0xc82005def8, 0x0)
        /usr/local/Cellar/go/1.5.1/libexec/src/testing/testing.go:494 +0x70
main.main()
        gopkg.in/Clever/optimus.v3/sources/gearman/_test/_testmain.go:56 +0x116

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
        /usr/local/Cellar/go/1.5.1/libexec/src/runtime/asm_amd64.s:1696 +0x1

goroutine 5 [chan receive]:
gopkg.in/Clever/optimus.v3/tests.GetRows(0x6b78e8, 0xc82000a7c0, 0x0, 0x0, 0x0)
        /Users/joshdeare/src/go/src/gopkg.in/Clever/optimus.v3/tests/test_table.go:32 +0xb5
gopkg.in/Clever/optimus.v3/sources/gearman.TestGearmanSource(0xc82007e120)
        /Users/joshdeare/src/go/src/gopkg.in/Clever/optimus.v3/sources/gearman/gearman_test.go:62 +0x82e
testing.tRunner(0xc82007e120, 0x59d2a0)
        /usr/local/Cellar/go/1.5.1/libexec/src/testing/testing.go:456 +0x98
created by testing.RunTests
        /usr/local/Cellar/go/1.5.1/libexec/src/testing/testing.go:561 +0x86d

goroutine 6 [runnable]:
gopkg.in/Clever/optimus.v3/sources/gearman.(*mockClient).Submit(0xc82000a740, 0x3e0ae0, 0x8, 0xc82000f500, 0x8, 0x8, 0x1160000, 0xc8200a6000, 0x1160030, 0xc8200aa000, ...)
        /Users/joshdeare/src/go/src/gopkg.in/Clever/optimus.v3/sources/gearman/gearman_test.go:25 +0xef
gopkg.in/Clever/optimus.v3/sources/gearman.(*table).start(0xc82000a7c0, 0x6b78b8, 0xc82000a740, 0x3e0ae0, 0x8, 0xc82000f500, 0x8, 0x8, 0xc82000a7a0)
        /Users/joshdeare/src/go/src/gopkg.in/Clever/optimus.v3/sources/gearman/gearman.go:57 +0x257
created by gopkg.in/Clever/optimus.v3/sources/gearman.New
        /Users/joshdeare/src/go/src/gopkg.in/Clever/optimus.v3/sources/gearman/gearman.go:76 +0x113
exit status 2
FAIL    gopkg.in/Clever/optimus.v3/sources/gearman      0.016s
make: *** [gopkg.in/Clever/optimus.v3/sources/gearman] Error 1
azylman commented 9 years ago

Welp, this scared me. Thankfully, it was only a bug in the tests. Take a look at https://github.com/Clever/optimus/pull/44 and let me know what you think.