search

Clever / optimus

Concurrently extract, transform, and load tables of data in Go
Apache License 2.0
34 stars 7 forks source link

sources/gearman: test: wait for packets #44

Closed azylman closed 9 years ago

azylman commented 9 years ago

These tests currently break on Go 1.5, where GOMAXPROCS defautls to NumCPU instead of 1.

Fixes #40

doodles526 commented 9 years ago

Looks good, as in I think it will fix these tests once gopkg is updated. But question, should imported packages in tests be changed to github.com/Clever/optimus/PACKAGE? Because as it stands we have to speculate that the tests pass with this update and would need to do the same in the future

Or update our local gopkg version to reflect any changes made

doodles526 commented 9 years ago

Derp. Just realized probably not a good idea since making changes to tests on github could break tests on gopkg

azylman commented 9 years ago

Not sure what you mean - we know the tests pass with this update. Drone shows it, and Drone runs this version of the code.