search

Clever / optimus

Concurrently extract, transform, and load tables of data in Go
Apache License 2.0
34 stars 7 forks source link

error if there are multiple fieldmaps #52

Closed jiancheung closed 8 years ago

jiancheung commented 8 years ago

We should error if there are multiple fieldmaps because otherwise we get undefined behavior.

jiancheung commented 8 years ago

cc @natebrennand

natebrennand commented 8 years ago

Do we have a list of repos that we need to update with this?

azylman commented 8 years ago

lgtm other than nit about error wording

jiancheung commented 8 years ago

@natebrennand @azylman any opinions of maybe just leaving the function as is and creating a SafeFieldmap transform instead to keep it backwards compatible? otherwise this will be a major revision bump.

azylman commented 8 years ago

personal opinion: this isn't a major version bump, it's a patch or minor bump. It's fixing a bug. It will break some consumers, but only ones that rely on buggy behavior, which is generally considered to be a patch version even if it causes breakages.