Clever / wag

sWAGger - Web API Generator
Apache License 2.0
77 stars 6 forks source link

DynamoDB support for x-nullable #415

Closed 18vijayb closed 2 years ago

18vijayb commented 2 years ago

JIRA: https://clever.atlassian.net/browse/INFRANG-3807

Overview:

Auto-generated code is manually modified due to x-nullable incompatibility. See https://github.com/Clever/family-invites-service/blob/647b092fc335f2bc9c73a302c03fe8cc8c09888e/Makefile#L34-L37 and https://github.com/Clever/integration-testing-service/blob/master/Makefile#L52

Testing:

Ran wag on the two repos above, and the manual changes were implemented by the auto-generated code

18vijayb commented 2 years ago

I ended up simplifying the code because I realized that I had to check if nullable was present in the pointer function simply enough, and there is a function that already handles pointers. Let me know what you think @tnsardesai , also added testcases based on those two repos linked above

taylor-sutton commented 2 years ago

Could you run make generate and commit the changes to samples/?