While testing the wag build from https://github.com/Clever/wag/pull/493 in a service where I was attempting to add a GSI using a date formatted string as hash key, I found wag was auto generating transaction functions multiple times.
Turns out the template to autogen transact functions are in the wrong range loop; currently they are in the GSI {{ range }} block but transact funcs should operate outside/independently of GSIs
review by commit
Testing
Tested against my own use case
Created a test case in db.yml for a before and after:
Before
After
Checklist
[x] Run make build
[x] Run make generate
[x] Update the current version in the /VERSION file. First line should be JUST the version e.g. v10.13.1. Then a blank line. Then release notes.
Jira
https://clever.atlassian.net/browse/DD-5762
Overview
While testing the wag build from https://github.com/Clever/wag/pull/493 in a service where I was attempting to add a GSI using a
dateformatted string as hash key, I found wag was auto generating transaction functions multiple times. Turns out the template to autogen transact functions are in the wrong range loop; currently they are in the GSI {{ range }} block but transact funcs should operate outside/independently of GSIs review by commitTesting
After
Checklist
make buildmake generate/VERSIONfile. First line should be JUST the version e.g.v10.13.1. Then a blank line. Then release notes.