search

CleverCloud / clever-components

Collection of Web Components by Clever Cloud
https://www.clever-cloud.com/doc/clever-components/
Apache License 2.0
215 stars 19 forks source link

cc-logs-application-view: make the date range selector accessible #1015

Open pdesoyres-cc opened 2 months ago

pdesoyres-cc commented 2 months ago

The actual implementation of the date range selector, using a drop-down quick selector, is not accessible.

Statement from @florian-sanders-cc :

We should replace the cc-popover with a component that implements the ARIA Combobox Design Pattern. This is no easy task so I suggest we do like we have done for the cc-pricing-header component and rely on the Shoelace Dropdown component.

Last time I checked, it was using the proper ARIA attributes + the right keyboard shortcuts. I cannot assert that it's 100% compliant (I would need time to test it and study its code) but it's the best option we have right now.

In the future, we may want to produce our own but I don't think we should go there right now. This is not up to me alone to decide so we can discuss it in team meeting?