CleverCloud / clever-components

Collection of Web Components by Clever Cloud
https://www.clever-cloud.com/doc/clever-components/
Apache License 2.0
215 stars 19 forks source link

refactor(cc-tile-metrics)!: rework properties to avoid impossible states #1059

Closed florian-sanders-cc closed 3 weeks ago

florian-sanders-cc commented 1 month ago

What does this PR do?

How to review?

Note: There are a few changes that you should review / pay more attention to. The grafana link now has a state of its own because its data comes from a separate source. It cannot be set to error because there is a fallback link within the smart. This may not be the best idea, I'm not really sure so don't hesitate to weigh in with other ideas / suggestions. On the contrary, the metricsLink is a simple property since it is not set by the smart and it does not depend on any API. This means that the metricsLink cannot be loading / in skeleton mode contrary to what we currently have in prod :thinking:.

github-actions[bot] commented 1 month ago

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-tile-metrics/state-migration/index.html.

This preview will be deleted once this PR is closed.

github-actions[bot] commented 3 weeks ago

🔎 The preview has been automatically deleted.