RFC: we need a modal/dialog system

CleverCloud / clever-components

Collection of Web Components by Clever Cloud

https://www.clever-cloud.com/doc/clever-components/

Apache License 2.0

217 stars 19 forks source link

RFC: we need a modal/dialog system #427

Open hsablonniere opened 2 years ago

hsablonniere commented 2 years ago

How does it work?
- How do I define the title?
- How do I define the body?
- How do I define list of buttons and their labels?
- We need a close button (top right corner) / same behaviour as esc key
- How do I trigger a modal?
- Can I modify the size?
- Can I modify the position?
We should use <dialog> but for old Safari versions, we'll need a polyfill/alternative

florian-sanders-cc commented 2 years ago

If we choose to use the Dialog Polyfill by Google Chrome, we should also use the Extension related to focus.

As stated in the readme, placing the focus back on the element that triggered the dialog after it closes was not part of the spec and thus is not part of the Polyfill (it is now part of the spec so the native dialog is ok :+1: )

florian-sanders-cc commented 2 years ago

This should fix #493.