Closed Galimede closed 1 year ago
As of today, every components have been switched from cc-error
to cc-notice
with some exceptions.
Indeed these components have not been changed for various reasons:
cc-addon-admin
=> there's a cc-error on top of the addon-admin
block. Putting a cc-notice
with blur in the background shouldn't be the way to go.
cc-addon-*-options
=> I've tried to change it from cc-error
to cc-notice
. But I wonder if the notice is too much visible. before:
after:
cc-tile-*
=> While I kept the change, I feel like cc-notice
is too small on the tile components.
cc-map
=> there's a cc-error
on top of the blurry map. Putting a cc-notice
with blur in the background shouldn't be the way to go.
cc-env-var-*
=> I feel like it's good but maybe a bit too big :thinking:
Feel free to give feedbacks on the screens (changes from the screens are not made in the code yet) and the information above.
Context
With the addition of the new
cc-notice
component there are places where we could use it instead of our actualcc-error
component.Components concerned
Problem
A few tests has already been made on some components and already some problems were found:
cc-header-*
are weird looking with the whole notice in the "box" on error