CleverCloud / clever-components

Collection of Web Components by Clever Cloud
https://www.clever-cloud.com/doc/clever-components/
Apache License 2.0
220 stars 19 forks source link

chore(storybook): upgrade to 8.0 & remove react deps #985

Closed florian-sanders-cc closed 6 months ago

florian-sanders-cc commented 6 months ago

What does this PR do?

How to review?

github-actions[bot] commented 6 months ago

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/storybook/upgrade-to-8/index.html.

This preview will be deleted once this PR is closed.

florian-sanders-cc commented 6 months ago

Do we want to opt-out of the Storybook telemetry? 🤔

Good question :+1:

florian-sanders-cc commented 6 months ago

Well done Flo.

Unfortunately, the stories and docs are broken for controllers and mixins.

Ah yes, thanks for this :muscle: I forgot to propagate the change done within markdown-to-csf to the story files of templates & controllers :sweat_smile:. The default export now contains the doc render function directly so they should rely on the default export directly.

github-actions[bot] commented 6 months ago

🔎 The preview has been automatically deleted.