Closed florian-sanders-cc closed 6 months ago
Note: if you modify a .d.ts
type file, it wont trigger cem again. Still, if you wanted to then modify the doc of the related component after modifying the .d.ts
, in hope that it would do the trick and reload cem, the type displayed will remain the same as before.
Note: if you modify a
.d.ts
type file, it wont trigger cem again. Still, if you wanted to then modify the doc of the related component after modifying the.d.ts
, in hope that it would do the trick and reload cem, the type displayed will remain the same as before.
As discussed in sync, this issue was already present with older storybook version. The d.ts
files are not actually seen as modules by the dev server so even if it detects a change, it does not trigger any refresh.
I've tried to solve it with the same logic as the one used within this PR but this didn't workout: the fact that these files are not recognized as dependencies of other files is the main issue.
I'll open an issue to see what we can do in the future but I'll merge this PR as is in the meantime.
Thanks @Galimede for pointing this out and testing with me :sunglasses:
🔎 The preview has been automatically deleted.
Fixes #989
What does this PR do?
viteFinal
config handling. We rely on themergeConfig
helper from vite to avoid erasing parts of the builder config by mistake. This is on par with the Storybook docs (see viteFinal - Storybook).mergeConfig
helper (although we could rely on thestorybook
node modules one) + the types. Note that since v8.0.0, storybook automatically adds vite to the dev dependencies so this feels like the right move anyway?How to review?