CleverCloud / clever-tools

The official command line interface for Clever Cloud
https://www.clever-cloud.com/
Apache License 2.0
74 stars 46 forks source link

Nix packaging: move to nixpkgs #748

Closed florian-sanders-cc closed 3 months ago

florian-sanders-cc commented 4 months ago

Context

The project documentation links to a third party repository to install the CLI with Nix.

As pointed out in #738, this repository is not maintained and would need to be updated.

We have been considering the subject of nix packaging lately and we think it would be better to move away from third party repositories and contribute the CLI package directly to the nixpkgs repository.

This would make it easier for users to install it and we would be in charge of maintaining the package.

We would also like to change the package code because Nix has evolved since the first versions of the CLI and there are new ways to package Node.js projects.

The package would rely on the Nix buildNpmPackage helper instead of patching the prebuilt Linux binary. There are several advantages to this:

An example of the code is available as a flake on a separate personal repo ( :warning: this is mostly a POC, do not use it as it will be deleted soon).

It should be easy to transform it for nixpkgs.

florian-sanders-cc commented 3 months ago

The PR is ready to be submitted on Nixpkgs but we'll wait for the next Clever Tools release (coming very soon) because it fixes the build for MacOS (see #754).

florian-sanders-cc commented 3 months ago

PR has been created : https://github.com/NixOS/nixpkgs/pull/319818

florian-sanders-cc commented 3 months ago

PR has been merged :tada: I've also closed an (old) issue from a customer on nixpkgs: https://github.com/NixOS/nixpkgs/issues/163506

I'll create a PR on this repo to update the docs about nix installation :+1: