legalEntity ignored in Party.php

CleverIT / UBL_invoice

MIT License

36 stars 39 forks source link

legalEntity ignored in Party.php #13

Open BabyDino opened 5 years ago

BabyDino commented 5 years ago

It is possible to set legalEntity with setLegalEntity() but it is never written to the XML

https://github.com/CleverIT/UBL_invoice/blob/e708803ecf440dea591938215386c5b6c1e8d54f/src/Party.php#L154

baselbers commented 5 years ago

I fixed it in my fork and will send a pull request when I'm all setup. https://github.com/baselbers/UBL_invoice/commit/0b87a4423373a5f57079662a53bb8567c55f5c48

BabyDino commented 5 years ago

Great, thanks. I found some other issues as well, will report accordingly :)

Is this the correct spec btw? https://stpe.t4smm.nl/#/TreeView/Message_1541344156_00959311

baselbers commented 5 years ago

I am using below link to validate the xml file. https://peppol.helger.com/public/locale-en_US/menuitem-validation-bis2

Using below link for specs. http://www.datypic.com/sc/ubl21/s-UBL-CommonAggregateComponents-2.1.xsd.html

And below link for some examples and descriptions. In Dutch do. https://www.softwarepakketten.nl/cmm/faq/wiki_subcat.php?id=1&bronw=7

Let me know if you find any issues. I will be happy to help.

yordivd commented 5 years ago

@baselbers I tried requiring your fork through composer but it's not working. can you give me a hand?

in composer.json

"repositories": [

    {
        "type": "vcs",
        "url": "https://github.com/baselbers/UBL_invoice"
    }
]

require command: composer require baselbers/ubl_invoice result:

[InvalidArgumentException]
Could not find a matching version of package baselbers/ubl_invoice. Check the package spelling, your version constraint and that the package is
available in a stability which matches your minimum-stability (stable).