CleverNucleus / RelicEx

Adds compatible trinket items for PlayerEx attributes.
MIT License
5 stars 10 forks source link

Breaking speed not working as intended (?) #38

Closed nixord closed 1 year ago

nixord commented 1 year ago

Hi again! Ive been trying out the breaking speed relics but it seems none of them affect the breaking speed of blocks at all. Ive tried with my modifiers as possible but I cant see any difference in the speed whatsoever. Is the difference supposed to be tiny or is the mod slightly bugged?

CleverNucleus commented 1 year ago

Hi there, The difference should be small, but I think the average value would be noticeable. I will add this to the list of things to take a look at. For now, I would advise trying it with just RelicEx and its dependencies installed to rule out unwanted mod interactions. Additionally, perhaps take a look to see if you notice a difference in block breaking speed if you increase the attribute value using the vanilla command or by a Data Attributes data pack and skilling it with PlayerEx. Thanks.

nixord commented 1 year ago

Ok! Thank you so much! I'd rather use Datapack but I STILL dont know how to use them. Are they easy to setup?

El mié, 22 feb 2023 a la(s) 15:55, CleverNucleus @.***) escribió:

Hi there, The difference should be small, but I think the average value would be noticeable. I will add this to the list of things to take a look at. For now, I would advise trying it with just RelicEx and its dependencies installed to rule out unwanted mod interactions. Additionally, perhaps take a look to see if you notice a difference in block breaking speed if you increase the attribute value using the vanilla command or by a Data Attributes data pack and skilling it with PlayerEx. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/CleverNucleus/RelicEx/issues/38#issuecomment-1440624192, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK3FW2DP7NOKHG64NUWUVJ3WYZOJDANCNFSM6AAAAAAVDZALZM . You are receiving this because you authored the thread.Message ID: @.***>

nixord commented 1 year ago

Also I tried using a datapack to change crit behaviour to vanilla but its throwing me this exception:

java.util.concurrent.CompletionException: com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was NUMBER at line 4 column 45 path $.values..

at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?]

at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) ~[?:?]

at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1770) ~[?:?]

at java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760) ~[?:?]

at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?]

at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?]

at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?]

at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?]

at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?]

El mié, 22 feb 2023 a la(s) 16:47, Nicolas Melnik @.***) escribió:

Ok! Thank you so much! I'd rather use Datapack but I STILL dont know how to use them. Are they easy to setup?

El mié, 22 feb 2023 a la(s) 15:55, CleverNucleus @.***) escribió:

Hi there, The difference should be small, but I think the average value would be noticeable. I will add this to the list of things to take a look at. For now, I would advise trying it with just RelicEx and its dependencies installed to rule out unwanted mod interactions. Additionally, perhaps take a look to see if you notice a difference in block breaking speed if you increase the attribute value using the vanilla command or by a Data Attributes data pack and skilling it with PlayerEx. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/CleverNucleus/RelicEx/issues/38#issuecomment-1440624192, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK3FW2DP7NOKHG64NUWUVJ3WYZOJDANCNFSM6AAAAAAVDZALZM . You are receiving this because you authored the thread.Message ID: @.***>

CleverNucleus commented 1 year ago

It looks like you've got a syntax issue with your JSON - would you send over your datapack/json file(s) and I can take a look at them? Thanks.

nixord commented 1 year ago

Sure! Here it is!

El jue, 23 feb 2023 a la(s) 09:53, CleverNucleus @.***) escribió:

It looks like you've got a syntax issue with your JSON - would you send over your datapack/json file(s) and I can take a look at them? Thanks.

— Reply to this email directly, view it on GitHub https://github.com/CleverNucleus/RelicEx/issues/38#issuecomment-1441720771, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK3FW2GON7MYVJYL24VOQBLWY5MULANCNFSM6AAAAAAVDZALZM . You are receiving this because you authored the thread.Message ID: @.***>

CleverNucleus commented 1 year ago

Hi, I think that you have not attached anything to your message.

nixord commented 1 year ago

Oh whoops, youre right. Well tbh I deleted the whole thing cause it wasnt working at all and got frustrated but ummm... Once I get another datapack going and I get the same error Ill tell you! Also sorry for taking so long to comment on it.

CleverNucleus commented 1 year ago

No worries; I'll close this issue for now then, but if the problem reoccurs feel free to reopen it.