search

CleverNucleus / data-attributes

Minecraft Fabric mod that overhauls the entity attributes system and exposes it with datapacks.
MIT License
12 stars 15 forks source link

Data Attributes crashes for no reason #16

Closed zoharTRP closed 2 years ago

zoharTRP commented 2 years ago

Crashy link with the details of the crash: https://crashy.net/Oiw5h6RRMWLXWHe2vdeZ I originally had player ex installed as well but I removed it for testing purposes Also if the only 2 mods I got installed are Data Attributes and fabric API it works

CleverNucleus commented 2 years ago

Hi there, Thank you for the report. Looking at the log I can see that this is a duplicate of #15; however, I can also see that Create for Fabric is not on the list of mods that were run. This is useful because it implies that create is not actually the mod conflicting with Data Attributes.

Therefore, even though this is technically a duplicate, I'm going to leave this open.

zoharTRP commented 2 years ago

Okay, I was messing with the mods and just found out that the fabric version of the twilight forest (ver: 1.18.2-4.1.232) is making Minecraft crash. You should check if #15 uses this mod if not then I don't know maybe certain types of mods make the game crash. Edit: tried the newer version of the twilight forest fabric (1.18.2-4.1.238) still the moment I add the mod it crashes and the moment I remove the mod it works

CleverNucleus commented 2 years ago

Interesting, I think you're probably correct: so far it seems mods that play about with attributes are incompatible. Obviously not ideal, considering the context of Data Attributes - I'll continue working on it.

TropheusJ commented 2 years ago

This is a duplicate of #15, both Create and TF use Porting Lib, which is the actual cause.

CleverNucleus commented 2 years ago

Hi there @TropheusJ, I agree, and have just seen the null check commit to prevent crashing. I appreciate the quick catch on that.

I will continue to work on this issue however, as the attribute instance should not be null in the first place - Data Attributes is definitely messing something up, I cannot have all mods that add attributes implement a null check just to cover for my bug, after all 🤣.

TropheusJ commented 2 years ago

See my comments on the Create issue for info, I tracked it down.

CleverNucleus commented 2 years ago

Fixed with release v1.1.8.