search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.48k stars 4.15k forks source link

Fuel consumption increased significantly #19348

Closed Coolthulhu closed 7 years ago

Coolthulhu commented 7 years ago

Fallout from #19275

Fuel consumption will need addressing. At the moment it is pretty heavy.

Asmageddon commented 7 years ago

Damn :-/ What other issues are there other than this? I don't think I noticed any, perhaps other than the maximum speeds of stuff seeming quite low.

kevingranade commented 7 years ago

This seems like a good place to drop some context since this is what I was working on when I made the decision to revert. I was executing the plan I outlined above, I had the target numbers added to the unit test and was looking at the code to determine how to correct the problem. What I found is that the propulsion overhaul had decoupled some key pieces of code that are needed to fix this efficiency problem, namely that the vehicle::thrust () method no longer consumed fuel, instead the vehicle::idle () method now did that. I was expecting to tweak some numbers to address this issue, but the more I looked at the code the more obvious it was that I would have to overhaul a large chunk of the overhaul in order to make things work right, which would be silly as the overhaul hadn't even delivered on what it was supposed to do, and mugling had stated he wasn't going to be working on it any time soon. At this point I decided to try a revert locally to see how difficult it would be, I expected it to take several days, but instead I wrapped it up in about 2 hours. Once I got things building the obvious course was to go ahead and push the revert and proceed from there.

Asmageddon commented 7 years ago

Ah. That's a shame. Well, thank you for the good work. I don't know how you manage to keep up at it for so many years.

mugling commented 7 years ago

and mugling had stated he wasn't going to be working on it any time soon.

There was an open PR (#19629) that you closed...

EDIT: Add link to PR

kevingranade commented 7 years ago

On Jan 12, 2017 2:15 PM, "mugling" notifications@github.com wrote:

and mugling had stated he wasn't going to be working on it any time soon.

Where?

That was here https://github.com/CleverRaven/Cataclysm-DDA/issues/19854#issuecomment-269378376