search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.26k stars 4.12k forks source link

Craters should disks not squares #2092

Closed dvolk closed 10 years ago

dvolk commented 11 years ago

Both individual craters and the overall shape of the nuclear missile explosion are square. They should probably be disks.

i2amroy commented 11 years ago

I'm not so sure about this. In a rougelike world like this squares are circles, so I'm just going to mark this one suggestion for now. If anybody has an opinion on it feel free to bring it up.

ejseto commented 11 years ago

Well, he's got a point if you're using circular LOS heh.

Eighth-of-Third commented 11 years ago

Well, he's got a point if you're using circular LOS heh.

This sort of inconsistency is why I was opposed to implementing that in the first place. Circular LOS is worse than Satan.

NicholasDM commented 11 years ago

We do have circular LOS, so I would recommend them being more dislike. `tis true.

Eighth-of-Third commented 11 years ago

We do have circular LOS, so I would recommend them being more dislike. `tis true.

We also have rogue LOS as the default, and in rogue LOS they're perfectly circular. Changing them to be more "disc-like" would mean making them square-like in rogue LOS.

kevingranade commented 11 years ago

this doesn't work with terrain features in general, but for craters in particular we could make them square/circular based on the los option. Never thought about the fact that if you use rl distance, squares and circles are identical "4 sides with equal length" vs "all points the same distance from the center"

NicholasDM commented 11 years ago

Izicata: To be honest, I'm fairly certain that we actually have circular LOS as the default, not rogue.

Eighth-of-Third commented 11 years ago

Izicata: To be honest, I'm fairly certain that we actually have circular LOS as the default, not rogue.

Nope, Circular Distances is disabled by default.

NicholasDM commented 11 years ago

Huh. Odd! I need to check my settings then-- Good to know.

i2amroy commented 11 years ago

Izicata: To be honest, I'm fairly certain that we actually have circular LOS as the default, not rogue.

This was actually changed from .6 to .7, in .6 they were mistakenly set as the default, in .7 they were set back to the intended setting.